hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

feat: Make h-table editable #240

Closed michaelbukachi closed 2 years ago

michaelbukachi commented 2 years ago

What is the Purpose?

Add inline edit support for the h-table.

What was the approach?

Briefly describe the approach used to address the issue

Are there any concerns to addressed further before or after merging this PR?

State some additional info if any. For instance running install or setting some environment variable(s)

Mentions?

Mention persons you'd like to review this PR @andrewtpham @ninetteadhikari

Issue(s) affected?

Resolves #46

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/6i66TTed9AMMjk2b63iDh7fR5J7b
✅ Preview: https://vue-ui-components-git-h-table-editable-hikaya.vercel.app

andrewtpham commented 2 years ago

@michaelbukachi left comment on the issue for remaining fixes before we merge this: https://github.com/hikaya-io/hakawati/issues/46#issuecomment-998076251

michaelbukachi commented 2 years ago

@andrewtpham already fixed them. What's left is the select issue.