hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

fix/htable styling #257

Closed ninetteadhikari closed 2 years ago

ninetteadhikari commented 2 years ago

What is the Purpose?

Updates to h-table component:

What was the approach?

CSS updates

Are there any concerns to addressed further before or after merging this PR?

None

Mentions?

@andrewtpham

Issue(s) affected?

None

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/CXj6DSqLZTCT8FVP4JNAcM2Coy5T
✅ Preview: https://vue-ui-components-git-fix-htable-styling-hikaya.vercel.app

andrewtpham commented 2 years ago

@ninetteadhikari it looks like the h-empty-table component preview is broken: https://vue-ui-components-git-fix-htable-styling-hikaya.vercel.app/?path=/story/table--h-empty-table

andrewtpham commented 2 years ago

@ninetteadhikari Is this the line that should be removed? I can see it under the h-table-empty in the latest preview: https://vue-ui-components-bbgqp48ih-hikaya.vercel.app/?path=/story/table--h-empty-table

image

ninetteadhikari commented 2 years ago

@ninetteadhikari Is this the line that should be removed? I can see it under the h-table-empty in the latest preview: https://vue-ui-components-bbgqp48ih-hikaya.vercel.app/?path=/story/table--h-empty-table

image

Ah no this line remains. The line is removed for h-table when there is data and the line remains when the table is empty. Let me know if this is ok this way