search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

(#255): scoped h-alert and h-form components #260

Closed amosnjoroge closed 2 years ago

amosnjoroge commented 2 years ago

What is the Purpose?

Mentions?

@andrewtpham ## Issue(s) affected?

List of issues addressed by this PR. https://github.com/hikaya-io/hakawati/issues/255

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/EGmNbLL3RRPXgE981WDjC6crp3CX
✅ Preview: https://vue-ui-components-git-255-scope-components-hikaya.vercel.app

andrewtpham commented 2 years ago

@amosnjoroge Looks good. I made some adjustments in the position of the ::v-deep and caught one that was missed.

If you want to keep working on scoping additional components (maybe ones that are little used in Dots FE - just do a quick search in the code base). We have a backlog of Dots FE PRs to merge so we shouldn't merge this yet until we clear that, namely, https://github.com/hikaya-io/dots-frontend/pull/1355 and https://github.com/hikaya-io/dots-frontend/pull/1359 since they touch hakawati.

amosnjoroge commented 2 years ago

@amosnjoroge Looks good. I made some adjustments in the position of the ::v-deep and caught one that was missed.

If you want to keep working on scoping additional components (maybe ones that are little used in Dots FE - just do a quick search in the code base). We have a backlog of Dots FE PRs to merge so we shouldn't merge this yet until we clear that, namely, hikaya-io/dots-frontend#1355 and hikaya-io/dots-frontend#1359 since they touch hakawati.

Hi @andrewtpham when you repositioned the ::v-deep the child elements are not affected by the css values set for the scoped elements. For example the h-alert's the .el-alert__title child element does not have a font size of 14, also for it to be scoped their should be a autogenerated attribute, see deep selectors scoping

Child element not affected by scope image

Child element affected by scope image

andrewtpham commented 2 years ago

Thanks @amosnjoroge that's good to know so we can revert my changes and go back to what you had previously.