Closed andrewtpham closed 2 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/7qdcx74uoJqQfLeMjEgLZcpvSJSa
✅ Preview: https://vue-ui-components-git-message-component-hikaya.vercel.app
Hi @andrewtpham The message stories look good. Since we are using 100% width, do you think we can centre the message so that we can have is properly distributed.
@amosnjoroge good point! Yes, I think we should center it. I've added it to the story. Also we should not use the default icon to keep with the figma designs, I'll update that too
What is the Purpose?
customClass
to use the correct styling and colorsTO DO:
theme.scss
toHMessage.vue
fileWhat was the approach?
Briefly describe the approach used to address the issue
Are there any concerns to addressed further before or after merging this PR?
$message
from Element.$message
is done under thetheme.scss
until we can figure out a better place for this to live.Mentions?
@amosnjoroge @myugetsu
Issue(s) affected?
List of issues addressed by this PR.