Feat/custom switch - Githubissues

hikaya-io / hakawati

A collection of UI components

GNU General Public License v3.0

2 stars 1 forks source link

Feat/custom switch #269

Closed ninetteadhikari closed 2 years ago

ninetteadhikari commented 2 years ago

What is the Purpose?

Add custom switch component. The following props are available:

custom-switch: this adds the custom styling to the switch
active-text-left="Add value e.g. 80px": this adds left space to the label on the right

What was the approach?

Add component and story

Are there any concerns to addressed further before or after merging this PR?

None

Mentions?

@andrewtpham

Issue(s) affected?

None

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/7e5uLCNvZcP5AvihXh65rQuywKDs
✅ Preview: https://vue-ui-components-git-feat-custom-switch-hikaya.vercel.app

andrewtpham commented 2 years ago

@ninetteadhikari Looks good! Can we try to make the width of one side of the switch 100px so in total it should be 200px? I think it looks nicer being longer. What do you think?

ninetteadhikari commented 2 years ago

@ninetteadhikari Looks good! Can we try to make the width of one side of the switch 100px so in total it should be 200px? I think it looks nicer being longer. What do you think?

it looks nice:) i'll makes the changes