feat(comp): added new button component with controls

hikaya-io / hakawati

A collection of UI components

GNU General Public License v3.0

2 stars 1 forks source link

feat(comp): added new button component with controls #280

Closed amosnjoroge closed 2 years ago

amosnjoroge commented 2 years ago

What is the Purpose?

Added new button component
Added controls

Mentions?

@michaelbukachi @andrewtpham @ninetteadhikari

Issue(s) affected?

https://github.com/hikaya-io/hakawati/issues/255

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/4zfTk86meEansk9F1nZY4E23PvNS
✅ Preview: https://vue-ui-components-git-255-hakawati-clear-up-hikaya.vercel.app

michaelbukachi commented 2 years ago

@amosnjoroge Looks good. Though I think we should combine all buttons into a single one instead of creating a new component in storybook.

amosnjoroge commented 2 years ago

@amosnjoroge Looks good. Though I think we should combine all buttons into a single one instead of creating a new component in storybook.

Thanks @michaelbukachi for the review. The reason I created a new button component is because this was like a POC for on how we would standardise the components without affecting the already created component. I will replace the component and create a new alpha version for hakawati.

vercel[bot] commented 2 years ago

@amosnjoroge is attempting to deploy a commit to a Personal Account on Vercel that is not owned by them.

In order for the commit to be deployed, @amosnjoroge must be granted access to the connected Vercel project.

If you're the owner of the Personal Account, transfer the project to a Vercel Team and start collaborating, or learn more.

netlify[bot] commented 2 years ago

Deploy Preview for hakawati ready!

Name	Link
Latest commit	4f814d35d4a8318168e3000d82118547cb325952
Latest deploy log	https://app.netlify.com/sites/hakawati/deploys/62625b7ac5d5030008cf5027
Deploy Preview	https://deploy-preview-280--hakawati.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ninetteadhikari commented 2 years ago

@amosnjoroge any idea why the checks are failing?