search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

fix: all h-button instances #288

Closed amosnjoroge closed 2 years ago

amosnjoroge commented 2 years ago

What is the Purpose?

Updated all h-button instances

What was the approach?

Briefly describe the approach used to address the issue

Are there any concerns to addressed further before or after merging this PR?

State some additional info if any. For instance running install or setting some environment variable(s)

Mentions?

@michaelbukachi @ninetteadhikari @andrewtpham

Issue(s) affected?

https://github.com/hikaya-io/hakawati/issues/287

vercel[bot] commented 2 years ago

@amosnjoroge is attempting to deploy a commit to a Personal Account on Vercel that is not owned by them.

In order for the commit to be deployed, @amosnjoroge must be granted access to the connected Vercel project.

If you're the owner of the Personal Account, transfer the project to a Vercel Team and start collaborating, or learn more.

netlify[bot] commented 2 years ago

Deploy Preview for hakawati ready!

Name Link
Latest commit c957fa585e4835b7200059c7e5d4f8a8f383269f
Latest deploy log https://app.netlify.com/sites/hakawati/deploys/626fd9c8cac2d60008b4111c
Deploy Preview https://deploy-preview-288--hakawati.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

andrewtpham commented 2 years ago

@amosnjoroge I've removed the vercel deployment so that should flag as a failure in the CI in the future

andrewtpham commented 2 years ago

@amosnjoroge do you think for consistency, we should also update all the el-button to use h-button in the component library as well?

I saw a few instance of this:

amosnjoroge commented 2 years ago

@andrewtpham I have updated the el-buttons except fro the ones on the nav bars (side and collapse nav). I think we can refactor these components by designing a new pull out component and transitions properly with the panel.

andrewtpham commented 2 years ago

Thanks @amosnjoroge reviewed and it looks good. Do we want to upgrade the hakawati version with this PR?

amosnjoroge commented 2 years ago

Thanks @amosnjoroge reviewed and it looks good. Do we want to upgrade the hakawati version with this PR?

Yes, thats the plan. please approve it and once it is merged to develop and published I will update dots with the new version.