Fix/h dialog type - Githubissues

hikaya-io / hakawati

A collection of UI components

GNU General Public License v3.0

2 stars 1 forks source link

Fix/h dialog type #310

Closed ninetteadhikari closed 2 years ago

ninetteadhikari commented 2 years ago

What is the Purpose?

Added type attribute to H-dialog

What was the approach?

Added type attribute to H-dialog

Are there any concerns to addressed further before or after merging this PR?

None

Mentions?

@andrewtpham

Issue(s) affected?

This will resolve the h-dialog component in dots that uses the type prop for determining if a dialog = primary, danger, etc. cc for reference @amosnjoroge

netlify[bot] commented 2 years ago

Deploy Preview for hakawati ready!

Name	Link
Latest commit	5dc7f5a2b3d306ab71bd2c7b6a7fa675cdb7813e
Latest deploy log	https://app.netlify.com/sites/hakawati/deploys/6299292ca8fcb600082ba597
Deploy Preview	https://deploy-preview-310--hakawati.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.