search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

Add custom color #315

Closed ninetteadhikari closed 2 years ago

ninetteadhikari commented 2 years ago

What is the Purpose?

Add custom color tag

image

What was the approach?

Add custom color prop

Are there any concerns to addressed further before or after merging this PR?

None

Mentions?

@Kimaiyo077 @andrewtpham

Issue(s) affected?

None

netlify[bot] commented 2 years ago

Deploy Preview for hakawati ready!

Name Link
Latest commit ae4e2df70752e229b97c8cb8f27b3beada025063
Latest deploy log https://app.netlify.com/sites/hakawati/deploys/62a1bac17b2d3b0009ddaa61
Deploy Preview https://deploy-preview-315--hakawati.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

andrewtpham commented 2 years ago

Looks good! After discussion w/ Ninette, we'll try to incorporate all the features of the h-tag into a single component following the v1.0 button using controls.

Marking this as WIP for now.

ninetteadhikari commented 2 years ago

@andrewtpham i consolidated the h-tag stories to one and the dynamic tag is a separate story. please have a look and let me know if there's anything else that needs to be added

ninetteadhikari commented 2 years ago

FYI: I have commented out 'dynamic tags'. I say we refactor it in a separate PR