search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

update caret display in edit mode #316

Closed Kimaiyo077 closed 2 years ago

Kimaiyo077 commented 2 years ago

What is the Purpose?

Update caret spacing to prevent style changing between edit and view modes

What was the approach?

Change top and bottom spacing values and display mode to flex

Are there any concerns to addressed further before or after merging this PR?

State some additional info if any. For instance running install or setting some environment variable(s)

Mentions?

@andrewtpham @ninetteadhikari

Issue(s) affected?

Closes #314

netlify[bot] commented 2 years ago

Deploy Preview for hakawati ready!

Name Link
Latest commit 45bc58ef624d68e41a28228cc9c313febfb565f5
Latest deploy log https://app.netlify.com/sites/hakawati/deploys/62a0c67d83f5180009424109
Deploy Preview https://deploy-preview-316--hakawati.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ninetteadhikari commented 2 years ago

hey Isaac was this supposed to solve the jumping of the table when switching view/edit mode? I still see it and I think its because of the sort icon. if we add the sort icon for the Edit mode as well then the jumping is solved. But the I think then we have to address this for both View and Edit mode: https://github.com/hikaya-io/hakawati/issues/313

table edit

andrewtpham commented 2 years ago

Hey @Kimaiyo077 nice, the columns are not jumping anymore. But it looks like we need to do the same for the first column (checkbox) and the fixed column on the right side (see highlight). The icons are jumping when you switch between view/edit

image
Kimaiyo077 commented 2 years ago

@andrewtpham I have fixed the checkbox but I am not able to fix the dropdown icon on the right. I am going to need a bit more time on it

andrewtpham commented 2 years ago

@andrewtpham I have fixed the checkbox but I am not able to fix the dropdown icon on the right. I am going to need a bit more time on it

@Kimaiyo077 @ninetteadhikari @amosnjoroge I think I was able to solve it. Can you have a quick look and confirm? To test, check these two stories:

amosnjoroge commented 2 years ago

@andrewtpham I have fixed the checkbox but I am not able to fix the dropdown icon on the right. I am going to need a bit more time on it

@Kimaiyo077 @ninetteadhikari @amosnjoroge I think I was able to solve it. Can you have a quick look and confirm? To test, check these two stories:

@andrewtpham The styling issue seems to been fixed, however when I sort the table, switch into edit mode, then edit the sorted column value and then switch back to view mode, the edit row is sorted to the bottom.

ninetteadhikari commented 2 years ago

@andrewtpham The styling issue seems to been fixed, however when I sort the table, switch into edit mode, then edit the sorted column value and then switch back to view mode, the edit row is sorted to the bottom.

Amos are you talking about the issue where after sorting a column, the row sequence is not updated and incorrect row gets edited? Its ticketed separately https://github.com/hikaya-io/hakawati/issues/313

andrewtpham commented 2 years ago

@amosnjoroge I cant seem to reproduce the sort issue. I would vote to handle this is a separate ticket. Would you mind creating the ticket or if its the same as the one @ninetteadhikari suggested #313 we can add to this one.