hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

Review `h-form` and `dialog` and where the set of `action` buttons should be part of #319

Closed andrewtpham closed 2 years ago

andrewtpham commented 2 years ago

Current behavior With 0.1.89 hakawati, we have introduced a new h-form that exposes a set of submit and cancel buttons as part of the h-form. These are currently set up to trigger any form validation on the input fields.

This conflicts with our h-dialog component or when we use standalone h-button and hook it up to h-from and we see both sets of buttons

If we decide to keep the buttons in the h-form we need to make the buttons not display by default so that way we can gradually refactor the buttons to use these. Currently about 20 files where h-form is being used

image

Expected behavior