search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

fix(h-form): Add form validation buttons #321

Closed ninetteadhikari closed 2 years ago

ninetteadhikari commented 2 years ago

What is the Purpose?

Add h-form validation

What was the approach?

Add form validation following el-form component

Are there any concerns to addressed further before or after merging this PR?

The form validation is working but not sure if it would be cleaner to have the validation function inside the component.

Mentions?

@Kimaiyo077 @andrewtpham

Issue(s) affected?

Resolve https://github.com/hikaya-io/hakawati/issues/319 Resolve https://github.com/hikaya-io/hakawati/issues/311

netlify[bot] commented 2 years ago

Deploy Preview for hakawati ready!

Name Link
Latest commit 67bb0f6f3cacb1f40a08272c29a88969a1de14c7
Latest deploy log https://app.netlify.com/sites/hakawati/deploys/62b4430900f981000822fbbf
Deploy Preview https://deploy-preview-321--hakawati.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

ninetteadhikari commented 2 years ago

@Kimaiyo077 can you please review this ticket and see if the form validation will work with out FE h-dialog component

ninetteadhikari commented 2 years ago

Add version upgrade and then merge