search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

enhance the button component to include an outline style #325

Closed amosnjoroge closed 2 years ago

amosnjoroge commented 2 years ago

Mentions?

@kohasummons @andrewtpham

Issue(s) affected?

Resolves https://github.com/hikaya-io/hakawati/issues/304

netlify[bot] commented 2 years ago

Deploy Preview for hakawati ready!

Name Link
Latest commit 0dc617becf7b542c9e0bc7f7ce18fa5a35922b45
Latest deploy log https://app.netlify.com/sites/hakawati/deploys/62bc5f37aeed610008cd69d0
Deploy Preview https://deploy-preview-325--hakawati.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

andrewtpham commented 2 years ago

@amosnjoroge to move the isOutline out of the isWorkspace prop into its own prop so it can be used with any button

andrewtpham commented 2 years ago

@amosnjoroge with my styling commit, I didn't adjust the styling for the :active and :focus states but I think it makes sense to wait until you refactor the outline into its own prop and if its using the standard button, I think we can avoid additional custom styling.

amosnjoroge commented 2 years ago

@amosnjoroge with my styling commit, I didn't adjust the styling for the :active and :focus states but I think it makes sense to wait until you refactor the outline into its own prop and if its using the standard button, I think we can avoid additional custom styling.

@andrewtpham I have refactored the button component so that each button style now as an option to have an outline.