search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

feat(h-button): update h-dialog button props #327

Closed amosnjoroge closed 2 years ago

amosnjoroge commented 2 years ago

What is the Purpose?

update h-dialog button props

Mentions?

@ninetteadhikari

netlify[bot] commented 2 years ago

Deploy Preview for hakawati ready!

Name Link
Latest commit 990b878e923341fedc0004c44675ba0c57c72f88
Latest deploy log https://app.netlify.com/sites/hakawati/deploys/62beafbb04ab0a0008d45124
Deploy Preview https://deploy-preview-327--hakawati.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

andrewtpham commented 2 years ago

@amosnjoroge I was looking at the styling for the isSecondary prop which is controlled by ws-button and text-style in theme.scss file. I'm wondering if text-style is still referenced in the h-button component? I was trying to make some styling tweaks in theme.scss but I dont see the changes taking effect as expected.

image
amosnjoroge commented 2 years ago

Hi @andrewtpham please checkout the below loom video and should the current behaviour of the secondary button (not sure if it is correct) as well as the style when the button in in focus and when it is clicked (active) and advice if thats the direction you want to go with the button.

https://www.loom.com/share/3b505949a26142be820887b4a3748d07

amosnjoroge commented 2 years ago

Looks good! Thanks @andrewtpham