search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

fix(NPM): set Node version to <= 14.20.0 #350

Closed TAnas0 closed 2 years ago

TAnas0 commented 2 years ago

What is the Purpose?

What was the approach?

None

Are there any concerns to addressed further before or after merging this PR?

None

Mentions?

@andrewtpham @ninetteadhikari

Issue(s) affected?

None

netlify[bot] commented 2 years ago

Deploy Preview for hakawati ready!

Name Link
Latest commit adec017c354d10f821c3d5995936a9af8126fd43
Latest deploy log https://app.netlify.com/sites/hakawati/deploys/62df10d79bc8f3000a6aa4e7
Deploy Preview https://deploy-preview-350--hakawati.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

andrewtpham commented 2 years ago

@TAnas0 do we need to upgrade the package version for this to get deployed to NPM and then subsequently get deployed to the DO app?

TAnas0 commented 2 years ago

@TAnas0 do we need to upgrade the package version for this to get deployed to NPM and then subsequently get deployed to the DO app?

@andrewtpham the deployment of the Storybook of Hakawati is totaly independent of the deployment of the NPM package. For the Storybook, that's deployed on DigitalOcean when update the develop branch. For the NPM package publishing, it happens in the CI.