hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

When hiding the last column in a `h-table`, there is a flicker in the table view #357

Closed andrewtpham closed 1 year ago

andrewtpham commented 2 years ago

Current behavior When you hide the last column in a h-table, you will see a flicker on the column header.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://hakawati.hikaya.dev/?path=/story/table--h-table-edit-enabled
  2. Click on more icon and hide a column
  3. See error

Expected behavior When a column is hidden, there should be no flicker in the table header

Screenshots See example in the Metrics > Configuration: hide-display-column-flicker

ninetteadhikari commented 2 years ago
andrewtpham commented 2 years ago

@Kimaiyo077 I realized the dropdown is coming from the settings icon instead of the actions table header. This could be contributing to the flicker that's happening since the settings icon is in the area where the table header expands when a column is hidden/displayed:

image

image

andrewtpham commented 1 year ago

Flicker is no longer shown since adding hide/display columns and vuex on Dots FE. @Kimaiyo077 to investigate and report back