search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

Update spreadsheet popup #406

Closed Kimaiyo077 closed 1 year ago

Kimaiyo077 commented 1 year ago

What issue(s) does this PR resolve?

Resolves partly https://github.com/hikaya-io/dots/issues/1746

Considerations and implementation

None

How to test

  1. Log in as ...
  2. Click on ...

Test(s) added

Mentions?

@andrewtpham

andrewtpham commented 1 year ago

Thanks @Kimaiyo077! Was testing locally, should the expand record menu item be enabled already in hakawati or is there more that will be implemented in dots once this PR is merged?

image
Kimaiyo077 commented 1 year ago

It shouldn't be enabled because for now it will only be implemented for Indicators on Dots. I have added a prop that will enable it on the spreadsheet where we will implement the expand dialog.

Kimaiyo077 commented 1 year ago

In fact @andrewtpham Can I just hide the add results and only show it on indicators?

andrewtpham commented 1 year ago

@Kimaiyo077 yes! That's a good idea to hide and only use it on indicators.