search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

feat: Allow right click of top nav items #409

Closed michaelbukachi closed 1 year ago

michaelbukachi commented 1 year ago

What issue(s) does this PR resolve?

Resolves #169

Considerations and implementation

How to test

  1. Log in as ...
  2. Click on ...

Test(s) added

Mentions?

@andrewtpham @ninetteadhikari

andrewtpham commented 1 year ago

@michaelbukachi when I click on table menu item, the menu item should use the is-active class and have a . below the menu item. Since it is now using a href, I can't seem to get this . to display.

Here is an example of what it should look like when a menu item is selected, see the Maps menu item: image

michaelbukachi commented 1 year ago

@andrewtpham The TopNav is stateless so it doesn't track which field is_active. I've also left the use a tag outside the library since we might not always want to have the link functionality by default.