search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

Label input (Issue 65) #69

Closed Tanvir-rahman closed 4 years ago

Tanvir-rahman commented 4 years ago

What is the Purpose?

Added Labeled input with required UI and disabled props as per the request. https://github.com/hikaya-io/vue-ui-components/issues/65

What was the approach?

Added another component as 'LabelInput'. Added props 'labelPosition', 'required', 'disabled' labelPosition can be set as 'top' / 'left'

Are there any concerns to addressed further before or after merging this PR?

No

Mentions?

@andrewtpham @michaelbukachi

Issue(s) affected?

Empty

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/pj2cd3jwr ✅ Preview: https://vue-ui-components-git-ui-65.hikaya.now.sh

Tanvir-rahman commented 4 years ago

Hello @michaelbukachi . I was thinking to solve this issue with all Input elements with this PR https://github.com/hikaya-io/vue-ui-components/issues/71 as improvement part :)

michaelbukachi commented 4 years ago

Wait. This PR is linked to which issue?

ninetteadhikari commented 4 years ago

Hello @michaelbukachi . I was thinking to solve this issue with all Input elements with this PR #71 as improvement part :)

Hey @Tanvir-rahman agreed that there's a separate ticket for removing the form wrapper (#71) but I suggest we keep this PR clean and use #71 for cleaning up the mentioned components there.

Tanvir-rahman commented 4 years ago

Hello @michaelbukachi . I was thinking to solve this issue with all Input elements with this PR #71 as improvement part :)

Hey @Tanvir-rahman agreed that there's a separate ticket for removing the form wrapper (#71) but I suggest we keep this PR clean and use #71 for cleaning up the mentioned components there.

Ok, as @michaelbukachi already mentioned we will loose the label because of removing parent form. So that's why at first we need to introduce another component for the parent form.

ninetteadhikari commented 4 years ago

Hello @michaelbukachi . I was thinking to solve this issue with all Input elements with this PR #71 as improvement part :)

Hey @Tanvir-rahman agreed that there's a separate ticket for removing the form wrapper (#71) but I suggest we keep this PR clean and use #71 for cleaning up the mentioned components there.

Ok, as @michaelbukachi already mentioned we will loose the label because of removing parent form. So that's why at first we need to introduce another component for the parent form.

Cool I created the form component issue as suggested #76 So is this PR currently blocked by #76 then? Or what do you suggest to move forward?

Tanvir-rahman commented 4 years ago

Hello @michaelbukachi . I was thinking to solve this issue with all Input elements with this PR #71 as improvement part :)

Hey @Tanvir-rahman agreed that there's a separate ticket for removing the form wrapper (#71) but I suggest we keep this PR clean and use #71 for cleaning up the mentioned components there.

Ok, as @michaelbukachi already mentioned we will loose the label because of removing parent form. So that's why at first we need to introduce another component for the parent form.

Cool I created the form component issue as suggested #76 So is this PR currently blocked by #76 then? Or what do you suggest to move forward?

Yep. This is blocked currently. Will be working on issue 76 soon :)

andrewtpham commented 4 years ago

@Tanvir-rahman is this ready to be merged?

Tanvir-rahman commented 4 years ago

Hello. @andrewtpham. Nope there was some dependency of Form Element. It resolved. Will give final push by today after optimization.

Tanvir-rahman commented 4 years ago

Pr is ready for review. However, changed required field color to $red as did not find any associated with orange color.