search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

Input field: remove form tag wrapper #71

Closed ninetteadhikari closed 4 years ago

ninetteadhikari commented 4 years ago

Current behavior Currently all the input fields are wrapped in form, row, column tags etc.

<el-form ref="form" model="form" label-width="120px">
        <el-row :gutter="20">
            <el-col class="grid-content" :span="12">
                <el-input
                    :placeholder="placeholder"
                    v-model="form.input">
                        <slot></slot>
                </el-input>
            </el-col>
        </el-row>
    </el-form>

Expected behavior The component will have only the input tag all other tags will be removed

<el-input
       :placeholder="placeholder"
        v-model="form.input">
              <slot></slot>
</el-input>

Additional info Clean up to be done for all input components: image

ninetteadhikari commented 4 years ago

hi @Tanvir-rahman thanks for catching this! I created an issue for this to clean it up :)

Tanvir-rahman commented 4 years ago

Hello @ninetteadhikari Before this we need to introduce another component which will expose form only. Ex: el-form. Will you please create another issue for that based on priority level?

ninetteadhikari commented 4 years ago

Hello @ninetteadhikari Before this we need to introduce another component which will expose form only. Ex: el-form. Will you please create another issue for that based on priority level?

@Tanvir-rahman here is the form component issue: https://github.com/hikaya-io/vue-ui-components/issues/76

Tanvir-rahman commented 4 years ago

This issue is ready to close now. @ninetteadhikari @andrewtpham