search

hikaya-io / hakawati

A collection of UI components
GNU General Public License v3.0
2 stars 1 forks source link

Pagination with page size #75

Closed Tanvir-rahman closed 4 years ago

Tanvir-rahman commented 4 years ago

What is the Purpose?

Introduced new component for Pagination with page size.

What was the approach?

Passing page-sizes and page-size props to root component

Are there any concerns to addressed further before or after merging this PR?

No

Mentions?

@andrewtpham @michaelbukachi

Issue(s) affected?

No

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/qg3vjut0q ✅ Preview: https://vue-ui-components-git-ui-52.hikaya.now.sh

Tanvir-rahman commented 4 years ago

Hi @ninetteadhikari as far as i know, nope that won't be possible with our current pagination support.For this requirement we need to introduce fully custom pagination(Inside project) and that will take some time.

And as my personal observation -

1) I didn't find that much references with this type of ui in some popular frameworks. That means this is the pretty popular way to traverse (Quasar, Vuetify, Elements, MdBootstrap etc).

2) For initial release i think this will be the ideal way to go. But If we really need that support, it will be best to make custom component inside project with this specific requirement. Might be it won't be possible to support in that way inside component library. Inside project we need some mapping between dropdown and pagination component.

And please let me know what do you think on this?

ninetteadhikari commented 4 years ago

Hi @ninetteadhikari as far as i know, nope that won't be possible with our current pagination support.For this requirement we need to introduce fully custom pagination(Inside project) and that will take some time.

And as my personal observation -

  1. I didn't find that much references with this type of ui in some popular frameworks. That means this is the pretty popular way to traverse (Quasar, Vuetify, Elements, MdBootstrap etc).
  2. For initial release i think this will be the ideal way to go. But If we really need that support, it will be best to make custom component inside project with this specific requirement. Might be it won't be possible to support in that way inside component library. Inside project we need some mapping between dropdown and pagination component.

And please let me know what do you think on this?

Ah I see, thanks for the clarification 🙂then I think for the first phase we leave it like this and then moving forward as we get more feedback from Katherine on the UI we can think about building something more custom.

Tanvir-rahman commented 4 years ago

Hello @ninetteadhikari. Do i need to follow any more extra step for this PR after your review?

ninetteadhikari commented 4 years ago

Hello @ninetteadhikari. Do i need to follow any more extra step for this PR after your review?

this should ok. I'll merge and close it