Closed andrewtpham closed 4 years ago
vercel[bot]
commented
4 years ago This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/hikaya/vue-ui-components/r764ie8qz ✅ Preview: https://vue-ui-components-git-color-styling.hikaya.now.sh
michaelbukachi
commented
4 years ago The shadow at the top of the workspace tab seems a bit off (blurry and not sharp). Is this the final look?
andrewtpham
commented
4 years ago The shadow at the top of the workspace tab seems a bit off (blurry and not sharp). Is this the final look?
@michaelbukachi Yeah I noticed that the shadow came out much stronger in storybook than in figma. I used the same dimensions as the CSS in figma but I'm hoping its just a storybook issue.
Also, I realized my styling on the active tab is now showing up on storybook either.
This is what it should look like:
Shadow here:
highlighted here:
michaelbukachi
commented
4 years ago Oh. I see.
lupyana
commented
4 years ago @andrewtpham I noticed there is the same import statement on multiple files i.e
@import "../../styles/theme";
Perhaps we can import it once in main.js, the classes will be available globally. Otherwise it looks great
andrewtpham
commented
4 years ago Everything is fixed but style scoped is making it so it doesnt render correctly in storybook. This is what it looks like locally
What is the Purpose?
Briefly describe what the PR addresses
What was the approach?
workspace buttonsworkspace tabAre there any concerns to addressed further before or after merging this PR?
Still some minor tweaks required:
workspace tab, need to figure out a way to display the selected tab output outside the card.Mentions?
@michaelbukachi @ninetteadhikari @Tanvir-rahman
Issue(s) affected?
List of issues addressed by this PR.