Closed hiker closed 3 months ago
Gee, fixing mypy involved some major changes to the import order :( But it should now really be ready for review.
Please check my merging of your "transformation script function" changes, that was a bit hairy :(
Oops! @hiker , after rebuilding the container and running the Gitlab pipeline of your Gitlab merge request, there seems to be a circular import error with running grab_lfric.py
. It imports BuildConfig, which initializes the tools and in tool PSyclone, there is a call to import BuildConfig. The error message is attached below (https://git.nci.org.au/bom/ngm/lfric/lfric_atm-fab/-/jobs/67568):
Start grabbing the lfric sources
Traceback (most recent call last):
File "....../fab_framework/infrastructure/build/fab/grab_lfric.py", line 10, in
Should we move fab.build_config import BuildConfig
in https://github.com/hiker/fab/blob/1109a8832c9137e3a6437f446248bfae06e59421/source/fab/tools/psyclone.py#L13 to def process
in fab/tools/psyclone.py
?
That should be ready for a first look.
Hmm - one issue is that git detects (correctly) that there will be conflicts with your changes. But I will only merge your changes in once they have been accepted by Matthew, otherwise I will risk resolving all the conflicts again :(