search

hiker / fab

Flexible build system for scientific software
https://metomi.github.io/fab/
Other
1 stars 0 forks source link

Add standard artefacts #28

Closed hiker closed 2 months ago

hiker commented 3 months ago

Replaces all strings as artefacts to enums. Users can still use strings if they need to create their own artefact sets.

hiker commented 3 months ago

Turns out I had to merge in bom_master to get git to properly detect that the changes to run_config are already there.

This PR replaces the strings defined in constant.py for artefact collections with enums in ArtefactSet - it esp. replaces the string constant "all_source" that is used. Otherwise it does a bit of additional cleanup. It looks big, but it is mostly change to imports (instead of constants.py the new ArtefactSet enum comes from artefact.py), and then replacing them where they are used. There is still one or two left for things that interact with e.g. the LFRic-specific configurator, but this will all properly be changed in the next PR.

hiker commented 2 months ago

Ready for next review.