search

hiker / fab

Flexible build system for scientific software
https://metomi.github.io/fab/
Other
1 stars 0 forks source link

Create artefact store #8

Closed hiker closed 5 months ago

hiker commented 6 months ago

The artefact store is originally just a dict. This introduces a new object that as the artefact store (which inherits from dict, so it behaves the same), but it allows us to add additional methods if required.

It also adds a getter in the BuildConfig (to avoid accessing the private member self._artefact_store)). I also fixed a few coding style issues (again something we need to figure out :) )

hiker commented 6 months ago

Taking this back, it actually fails some CI tests that I must have missed :(

hiker commented 5 months ago

Thanks for the review. I've updated the PR, flake8 and CI seems to be fine. Ready for next review,