search

hikerpig / gatsby-project-kb

Developing gatsby-theme-kb, a Gatsby theme for publishing Knowledge Base.
https://gatsby-project-kb.vercel.app/
MIT License
62 stars 15 forks source link

Rough notation support #16

Closed zubayrrr closed 3 years ago

zubayrrr commented 3 years ago

Hi, I was messing around with gatsby-theme-code-notes and I ported rough notations over to gatsby-project-kb, do you think this feature will be a nice addition to gatsby-project-kb? if yes, I'll make a PR, thank you.

Here is the demo for rough notations

hikerpig commented 3 years ago

Hi @zubayrrr, it's one pretty nice feature to have, but can this be provided as a seperate gatsby plugin instead of directly into the gatsby-theme-kb?

zubayrrr commented 3 years ago

No, unfortunately it cannot be used as a plugin, they're more like custom MDX components.

let me make a PR real quick so you can check for yourself, I'm really bad at explaining 😅

hikerpig commented 3 years ago

No, unfortunately it cannot be used as a plugin, they're more like custom MDX components.

let me make a PR real quick so you can check for yourself, I'm really bad at explaining 😅

Sure. 😀