hikerpig / pintora

An extensible text-to-diagrams library that works in both browser and node.js
https://pintorajs.vercel.app
MIT License
1.08k stars 22 forks source link

optimize(cli): should cleanup global pollution after render #261

Closed hikerpig closed 4 months ago

hikerpig commented 4 months ago

A quick but not perfect fix for #237

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pintorajs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 2:10pm
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 96.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.82%. Comparing base (87f80b1) to head (8a148a0). Report is 137 commits behind head on master.

:exclamation: Current head 8a148a0 differs from pull request most recent head 2fed43a. Consider uploading reports for the commit 2fed43a to get more accurate results

Files Patch % Lines
packages/pintora-cli/src/render.ts 96.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #261 +/- ## ========================================== + Coverage 91.06% 91.82% +0.76% ========================================== Files 69 88 +19 Lines 3994 5165 +1171 Branches 762 915 +153 ========================================== + Hits 3637 4743 +1106 - Misses 357 422 +65 ``` | [Flag](https://app.codecov.io/gh/hikerpig/pintora/pull/261/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hikerpig) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/hikerpig/pintora/pull/261/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hikerpig) | `91.82% <96.00%> (+0.76%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hikerpig#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.