search

hikerpig / pintora

An extensible text-to-diagrams library that works in both browser and node.js
https://pintorajs.vercel.app
MIT License
1.08k stars 22 forks source link

Allow switching off the border of a participantBox in Sequence Diagram #291

Closed RolfBremer closed 3 weeks ago

RolfBremer commented 1 month ago

It would be nice to have participant boxes defined only by their background, without surrounding lines. The diagram is much more clear then. I found settings for the padding an background color, but none for the border.

I really like the package, btw.!

hikerpig commented 1 month ago

Sure, this new param paritipantBorderColor will do . Wait for the PR to be merged and new package version published. An example from Vercel preview page

image
RolfBremer commented 3 weeks ago

We updated the pintora/cli package to 0.7.5, but the participantBorderColor setting does not work at all. We tried it in the vscode preview as well as with the pintora command line. We tried transparent as well as red, but no success.

hikerpig commented 3 weeks ago

@RolfBremer The vscode package is not updated yet. Could you check if @pintora/diagrams is also updated to 0.7.4 ? The modification is actually in this package .

RolfBremer commented 3 weeks ago

Yes, it is also 0.7.4.

RolfBremer commented 3 weeks ago

Got the VSCode Extension today, but it says deepmerge$1 is not a function in the preview window.

hikerpig commented 3 weeks ago

@RolfBremer Yeah I made some mistakes publishing the vscode extension last night. Sorry about that. Try pintora-vscode 0.9.5 and it's alright now.

image
RolfBremer commented 3 weeks ago

VSCode extension 0.9.5 works like a charm now! Thank you! The npm package 0.9.4 still does not.

RolfBremer commented 3 weeks ago

We tried the npm package with node versions 18.16, 20.10, 20.11.1 and 20.14, but no success. The box border is always black.

hikerpig commented 3 weeks ago

Mind I ask how do you use it ? Do you

  1. use pintora cli directly ?
  2. import @pintora/cli as a package and write some other code to call its exported methods?
RolfBremer commented 3 weeks ago

We used it like option 1.:

pintora render -i test.pintora -o test.svg
hikerpig commented 3 weeks ago

I think I found the reason, I don't have a clean output directory in my laptop, some old files stays in it.

@RolfBremer try @pintora/cli@0.7.6 , I've tested it with option 1, it works.

Thank you for the try.

RolfBremer commented 3 weeks ago

Now it works! Great! Thank you!

RolfBremer commented 3 weeks ago

I am not sure who is supposed to close an issue. For me, this is solved, so I dare to close it.