search

hikikomoriphoenix / Beedio

Android app that lets you find downloadable videos as you browse the web. Allows queuing downloads. Also includes bookmarking and ad-blocking features for easier browsing experience.
GNU General Public License v2.0
148 stars 44 forks source link

Making continuous sound while downloadind #61

Closed codewithrish closed 4 years ago

hikikomoriphoenix commented 4 years ago

Did you use it on the emulator or on the real device? If real device, what device and what version? I had this same experience in the emulator.

codewithrish commented 4 years ago

its basically crashing give null pointer exception. I had to modify this snippet

public static void forceStopIfNecessary() { if (downloadThread.isAlive()) { stop = true; } }

to

public static void forceStopIfNecessary() { if (downloadThread != null && downloadThread.isAlive()) { stop = true; } }

and now its working but making continuous sound on both emulater and physical device

Device (Moto G4 Plus : Android Version 8.1)

hikikomoriphoenix commented 4 years ago

First of all, I am very sorry for the crash. I was not able to thoroughly test a previous fix. I made the app last year, and I did not write any unit tests. Which is why I would not know if I'm breaking things.

For the sound, I discovered it was coming from the downloadNotifier. It updates the notification progress every second, hence the continuous sound. The sound should be disabled by setting the notification's importance to low. Fix will be coming.

hikikomoriphoenix commented 4 years ago

Fixed. Check new release.

codewithrish commented 4 years ago

Great It's working fine now. Thanks