search

hikirsch / htd_mc-home-assistant

An integration for the HTD MC/MCA-66 Series for Home Assistant
MIT License
17 stars 17 forks source link

HtdDevice using deprecated supported features #7

Closed markus99 closed 6 months ago

markus99 commented 9 months ago

Just upgraded to 2024.1 and seeing these error msgs in logs:

Logger: homeassistant.helpers.entity Source: helpers/entity.py:1524 First occurred: 12:45:08 PM (12 occurrences) Last logged: 12:45:08 PM

Entity None (<class 'custom_components.htd_mc.media_player.HtdDevice'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <MediaPlayerEntityFeature.VOLUME_SET|VOLUME_MUTE|TURN_ON|TURN_OFF|VOLUME_STEP|SELECT_SOURCE: 3468>, please report it to the author of the 'htd_mc' custom integration and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

Unfortunately I'm not savvy enough to fix, so posting here. Thx!

markus99 commented 8 months ago

Realize there's some time until 2025.1, but wanted to bump this issue. Thx @hikirsch!

hikirsch commented 8 months ago

Realize there's some time until 2025.1, but wanted to bump this issue. Thx @hikirsch!

Hey Markus!

Thanks for the ping! I didn't notice this warning thanks for calling it out, I agree I'll find time soon and make these updates, they look simple enough.

Will keep you all posted.

--Adam

hikirsch commented 7 months ago

Hey @markus99 can you try updating this from HACS ;-) and let me know how it goes. Once you're able to confirm, I'll close the issue and announce the new HACS integration. Thank you for calling this out!

hikirsch commented 6 months ago

closing, will open another issue if there are issues.

UngluedChalice commented 2 months ago

So I'm trying to update my fork which is for HTD Lync 12, but I'm not a programmer at all. Any tips on what needs to change?

I was thinking these lines need to update, but if I try to fix it by the guess-and-test method, I already know it will never work. 

SUPPORT_HTD_Lync12 = (
    SUPPORT_SELECT_SOURCE
    | SUPPORT_TURN_OFF
    | SUPPORT_TURN_ON
    | SUPPORT_VOLUME_MUTE
    | SUPPORT_VOLUME_SET
    #| SUPPORT_VOLUME_STEP

Sorry if this is the wrong spot for it, but I'm not sure where else to post.