search

hikitae / homework-landingpage

0 stars 0 forks source link

Feedback on Relaxr Blog #2

Open barryross opened 7 years ago

barryross commented 7 years ago

FEWD Week #3 Project: CSS Layouts

Description

Relaxr was really impressed by your work last week and wants you to continue development on their landing page. Starting in class, you will work to build out a more complex layout for their company site. They decided on creating a blog, and their back-end engineers will be focused on developing the blog's functionality. They want your front-end skills to style their designs using HTML and CSS so Relaxr's engineers can begin integrating. Once again, the designers have handed you a basic design file with instructions and the JPEG below to help you bring the blog to life. Submit the finished version for homework.

Student: Emi Hikita

Project URL: https://github.com/hikitae/homework-landingpage/tree/master/starter_code
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use in-line-block or floats in your CSS to achieve a two-column layout x
Use the correct Open Sans Google Font typeface to style the text denoted in the design file and according to the JPEG provided x
Use proper filename conventions (lowercase, .html) x
Use a single external CSS stylesheet to style all pages x
Use <img> tags for the headers of the posts x
Add a hover effect to all the links using pseudo-classes x
Integrate drop caps using pseudo-classes x
TOTAL: 12/14
barryross commented 7 years ago

Hey Emi,

Great work on this assignment! You are doing some great things here! There are a couple things I wanted to point out about the float/inline-block implementations you have, and I noticed that while you have done a great job matching font-weights to the design spec, a number of the font-sizes are different than the spec. Those are the reasons for the missing marks on the rubric. Please let me know if the font-sizes were intentionally smaller for aesthetics.

Keep up the great work and please see inline comments for additional feedback!

hikitae commented 7 years ago

Hi Barry,, regarding the font size, according to your advice, i added this message --> / intentionally different than design spec / ,, so it was intentionally done. Sorry for the confusion.

barryross commented 7 years ago

Oops, sorry...my bad! You absolutely did, and I overlooked that. Thank you for including the comments throughout your CSS, and reminding me. I'll adjust the marks now! My initial comments were based on reviewing your CSS in the console, rather than looking directly at your file. I see the thorough descriptions now! Great work 😄