hil-se / fds

DSCI-633: Foundations of Data Science https://github.com/hil-se/fds
MIT License
26 stars 10 forks source link

Assignment 10: Decision Boundary Formatting for List of Floats #115

Closed thapa-jeevan closed 10 months ago

thapa-jeevan commented 10 months ago

For Assignment 10, the decision boundary for min_impurity_decrease has integer for the start value ("min_impurity_decrease": [0, 0.1]) in A10.py line 30. Since the data type of list elements is determined by the first element, this setup could pose a problem. If the boundary is configured similarly (with starting integer starting value) in the assignment evaluation pipeline, all sampled values will be rounded off. This might not be desirable for float boundaries.

azhe825 commented 10 months ago

Good point. I have updated A10.py file to make it [0.0, 0.1]. The actual grading files do not have such problem.

thapa-jeevan commented 10 months ago

Thank you! Closing the issue.