search

hilburn / NotEnoughResources

Adds resources to NEI
Other
20 stars 17 forks source link

Hello! #24

Closed Lanse505 closed 9 years ago

Lanse505 commented 9 years ago

I got Sent here by the mod dev of Ancient Warfare 2 after i have looked up this crash.

http://pastebin.com/hPwq5kR7

This is the original post: https://github.com/shadowmage45/AncientWarfare2/issues/191

way2muchnoise commented 9 years ago

@Lanse505 What is the version you are using make sure to get the latest build from the Jenkins

Lanse505 commented 9 years ago

we are running 77

way2muchnoise commented 9 years ago

@Lanse505 What item are you trying to lookup? (Mod and version of it to if applicable)

Lanse505 commented 9 years ago

Let me ask as soon as I come back to a computer I'm at my in-laws

Lanse505 commented 9 years ago

This is how it happens:

"Hi,

When i right click the engineering AW station with a stack of oak wood planks it crashes the server and all items inside the crafting grid of the engineering station are "lost" (simply gone after relog).

If I use a single oak wood plank it does not crash."

Its using Ancient Warfare v.2.3.78-BETA-MC1.7.10

When we posted this on the Ancient Warfare Devs Github he promptly pointed us here :P

pterolatypus commented 9 years ago

The problem is a reference to a nonexistent vararg in NEIPlantHandler.loadUsageRecipes. I've chucked a pull request at you which should fix it, but do ignore me if I've misunderstood.

EDIT: What I meant is; I'm sure this is part of a wider issue, (why that method is being called in the first place) but this pull serves as a hotfix. And you should really be doing that check for varargs anyway 'cause you never know when some cowboy's gonna come in and abuse your code. Xx.

hilburn commented 9 years ago

looks good, would appreciate you testing when jenkins has built it

pterolatypus commented 9 years ago

Similar issue exists in NEIAdvSeedHandler. I'm just setting up a workspace so I can test locally and avoid wasting your time with a million and one pull requests.

pterolatypus commented 9 years ago

Struggling to set up my workspace, it's been too long since I did this. Anyway; pushed the change, will test in the morning if necessary.

hilburn commented 9 years ago

@way2muchnoise - not your finest work my friend :P

way2muchnoise commented 9 years ago

@hilburn Keep calm and finish restrictions

pterolatypus commented 9 years ago

Tested build #79 and am now unable to reproduce, I'm calling this fixed.