search

hilburn / NotEnoughResources

Adds resources to NEI
Other
20 stars 17 forks source link

API is not a api #56

Closed Speiger closed 8 years ago

Speiger commented 8 years ago

Just got started on the NER support for IC2 classic loading all API files in then... What happens... Right the API requires ModClasses. Even really Deep core classes... That you should fix...

way2muchnoise commented 8 years ago

What? Could you point out where it requires ModClasses?

Speiger commented 8 years ago

https://github.com/hilburn/NotEnoughResources/blob/master/src/main/java/neresources/api/messages/SendMessage.java#L7 And line 6

so it requires the Message registry and the config class which requires the settings class which requires a lot more other classes which mean you require the whole mod... and a couple submods

way2muchnoise commented 8 years ago

ah those shouldn't be in the API my bad, that is/was some WIP stuff

Speiger commented 8 years ago

Simply the API should be build and stored in his own seperate area. And the Mod is reading out of it. Else it would not work. (Talking from experience)

way2muchnoise commented 8 years ago

I know what an API is and how it is supposed to work. I was working on things and never continued with it so it was some WIP stuff that wasn't cleaned properly

Speiger commented 8 years ago

I do not blame you or something just wanted to help^^ Anyway thanks for fixing.