search

hilburn / StevesAddons

Additional functionality for SFM
Other
17 stars 10 forks source link

Crafting Bug in SFM #47

Closed Grimjahk closed 9 years ago

Grimjahk commented 9 years ago

I found a Bug in SFM while playing Agrarian Skies 2. (not sure which version of SFM, but I think it was latest as it has the "Copy" function that I had not seen before. (I'm really hoping you guys can help because I love this mod, but Jadedcat pulled it from her AS2 pack for now until it gets fixed.)

Somehow, the way I set up my crafting command structure was allowing crafting to complete with insufficient materials.

I reproduced this bug on an older copy of SFM in the current version of ME^4.

Nesting Command groups is the culprit

Layer1: Trigger and CG1(command group1) Layer2: Node-CG2-Node Layer3: Node-CG3-Node Layer4: Node-Test1(CG)-Test2(CG)-Test3(CG)-Test4(CG)-Test5(CG)-Node

Test1: Node-Input-Crafter(planks->Crafting Tables)-Output-Node Test2: Node-Input-Crafter(Sticks->Fences)-Output-Node Test3: Node-Input-Crafter(Dirt-Compressed Dirt)-Output-Node Test4: Node-Input-Crafter(Iron Ingot-Iron Chestplate)-Output-Node Test5: Node-Input-Crafter(stuff-redstone Comparator)-Output-Node

With this setup the first item in the line will always work correctly, (Must have four planks to make one Crafting table) However every line after that requires only the top line of the crafting recipe to complete and at least one of the remaining materials (3 sticks will complete a fence, 3 dirt will complete a Compressed Dirt, 2 Iron Ingots will complete an Iron Chestplate, one Redstone torch, one Nether Quartz, and One Stone will produce One Comparator)

way2muchnoise commented 9 years ago

Since @hilburn is doing a complete clean of SFM in AFM it will probably get fixed there

hilburn commented 9 years ago

Right - is this a SFM bug or SA bug - can you reproduce it without SA?

Grimjahk commented 9 years ago

In Material Energy ^4 there is no SA and that is the pack I reproduced the bugs in

On Apr 21, 2015, at 9:13 AM, hilburn notifications@github.com wrote:

Right - is this a SFM bug or SA bug - can you reproduce it without SA?

— Reply to this email directly or view it on GitHub https://github.com/hilburn/StevesAddons/issues/47#issuecomment-94856683.

hilburn commented 9 years ago

Ok - then I am unlikely to be able to fix this

Grimjahk commented 9 years ago

Well poop.. So this bug will also be there in ASM?

hilburn commented 9 years ago

ASM? AFM - though I might rename it to Advanced Inventory Manager for the AIM acronym

And no it will not

Grimjahk commented 9 years ago

LOL I meant AFM... That is awesome news..

AIM... Well then you could say that any pack without your mod would be AIMless...

Since I just found out about this today, I have to ask... Is it stable enough for testing? Or close to release?

hilburn commented 9 years ago

Since I started it yesterday no - nowhere near close

Maybe after the weekend I'll have something simple but stable with the right framework in place

Grimjahk commented 9 years ago

Well I wish you the best of luck and speed ;-)

On Tue, Apr 21, 2015 at 5:46 PM, hilburn notifications@github.com wrote:

Since I started it yesterday no - nowhere near close

Maybe after the weekend I'll have something simple but stable with the right framework in place

— Reply to this email directly or view it on GitHub https://github.com/hilburn/StevesAddons/issues/47#issuecomment-94985219.

hilburn commented 9 years ago

I've identified this issue - is fixed as of 0.10.6 Interestingly it actually had nothing to do with the nested nodes, it was just from inputting from the same chest more than once before the crafter