search

hildensia / bayesian_changepoint_detection

Methods to get the probability of a changepoint in a time series.
MIT License
670 stars 213 forks source link

New release in PyPi? #32

Closed lisabutti closed 2 years ago

lisabutti commented 3 years ago

Is it possible to get a new release in PyPi? since the offline detection does not work in the release currently in PyPi.

Thank you

MakGulati commented 3 years ago

@lisabutti are you getting some scipy import problems?

lisabutti commented 3 years ago

@MakGulati yes when I try to import the offline_changepoint_detection

MakGulati commented 3 years ago

basically scipy developers modified the modules for imports. For instance logsumexp is now in scipy.special. I can create a pull request with my changes if it makes sense. @hildensia @lisabutti

sayanchk commented 2 years ago

Is there any progress in this issue? Can we make a new release in pypi with support to the latest scipy versions?

We have dependency on this package and blocked to support the latest scipy releases.

hildensia commented 2 years ago

If somebody does a pill request I'm happy to merge it

MakGulati commented 2 years ago

@sayanchk @hildensia @lisabutti Recent commit (one month ago) by David Nicholson addresses this scipy import issue. If you try updated example notebooks, it should work just fine.

sayanchk commented 2 years ago

@hildensia @MakGulati This package is part of our dependency and we install it on the fly whenever we pip install our package. Therefore, we need it pypi.

I am not seeing any instruction for the CI/CD. Can you please share how to make the latest version (0.3) available in pypi? I can then make the necessary changes.

sayanchk commented 2 years ago

Hi all,

I understand that the scipy issue has been addressed in the recent changes but the issue has not been pushed to pypi. The cd for our luminaire package is failing since it was not able to download the latest changes from pypi: https://github.com/zillow/luminaire/actions.

We tried to bypass the issue by adding the git hash of the latest change in bayesian changepoint detection: (https://github.com/zillow/luminaire/runs/5469641178?check_suite_focus=true) but pypi doesn't like the way of passing the url and we couldn't find an easy way to solve it.

So, I can see the latest version in pypi is this: https://pypi.org/project/bayesian-changepoint-detection/

Now, the owner of this repo in pypi should be able to push the latest release to pypi.

I found this a good example here on how to publish a project in pypi: https://dev.to/wangonya/publishing-your-python-packages-on-testpypi-before-publishing-on-pypi-2gb2

cc: @hildensia @MakGulati @lisabutti

shahsmit14 commented 2 years ago

I have created a PR to help resolve this issue and requires creating a token which is defined in the description.
https://github.com/hildensia/bayesian_changepoint_detection/pull/35

shahsmit14 commented 2 years ago

Can I get some eyes on the PR? cc: @hildensia

hildensia commented 2 years ago

Fixed by #35