hildensia / bayesian_changepoint_detection

Methods to get the probability of a changepoint in a time series.
MIT License
670 stars 213 forks source link

R matrix in online_changepoint_detection function #41

Open cubesnyc opened 4 months ago

cubesnyc commented 4 months ago

Please correct me if I am wrong.

It seems like the R matrix is conflating the joint probability and the conditional probability. The last step in the iteration turns it into a conditional probability. When you then calculate the growth/changepoint probabilities, you are using the conditional probabilities instead of the joint probabilities as depicted in the paper.