search

hildensia / bayesian_changepoint_detection

Methods to get the probability of a changepoint in a time series.
MIT License
670 stars 213 forks source link

Corrected scale and beta factor calculation #7

Closed nariox closed 9 years ago

nariox commented 9 years ago

The scale factor should be the standard deviation. There was a small bug in the betaT0 calculation, this makes it consistent with the paper/gaussdemo.m file.

hildensia commented 9 years ago

Hi. I've seen your patch, but I'm not really available for the next couple of days. I'll merge it afterwards. Ping me in ~14 days if nothing happens. Thanks for your patience.

nariox commented 9 years ago

No problem, take your time. I have some suggestions for the example notebook as well. Would you rather have me wait a little before submitting those?

Pedro Nariyoshi

On Tue, Jul 28, 2015 at 5:09 PM, Johannes Kulick notifications@github.com wrote:

Hi. I've seen your patch, but I'm not really available for the next couple of days. I'll merge it afterwards. Ping me in ~14 days if nothing happens. Thanks for your patience.

— Reply to this email directly or view it on GitHub https://github.com/hildensia/bayesian_changepoint_detection/pull/7#issuecomment-125754861 .

hildensia commented 9 years ago

Just make a PR whenever fits you. I'll go through it when I have time.

Sent from my mobile device. Please excuse my brevity and typos.

On July 29, 2015 4:32:15 AM GMT+02:00, pedronariyoshi notifications@github.com wrote:

No problem, take your time. I have some suggestions for the example notebook as well. Would you rather have me wait a little before submitting those?

Pedro Nariyoshi

On Tue, Jul 28, 2015 at 5:09 PM, Johannes Kulick notifications@github.com wrote:

Hi. I've seen your patch, but I'm not really available for the next couple of days. I'll merge it afterwards. Ping me in ~14 days if nothing happens. Thanks for your patience.

— Reply to this email directly or view it on GitHub

https://github.com/hildensia/bayesian_changepoint_detection/pull/7#issuecomment-125754861 .

Reply to this email directly or view it on GitHub: https://github.com/hildensia/bayesian_changepoint_detection/pull/7#issuecomment-125813948