search

hildjj / dohdec

Lookup and decode DNS records using DNS-over-HTTPS (DoH)
MIT License
21 stars 5 forks source link

Using url.domainToASCII instead of punycode #18

Closed imcotton closed 3 years ago

imcotton commented 3 years ago

By using url.domainToASCII would reduce external dependency of punycode.

hildjj commented 3 years ago

I like this. Can you add a contributors section to package.json with your name in it, please? It would also be great to add a test for a non-ASCII domain, if you can figure out the Ava test fixtures stuff. If it's not immediately obvious, though, I'll re-figure it out and add in a test.

imcotton commented 3 years ago

I took one non-ASCII test case from Node.js repo for sanity check here, also thanks for reminding of contributors additions, I'd like to remain as it is if not mandated.

hildjj commented 3 years ago

It's not mandatory to add yourself to the contributors, but the downside is if I ever need to do something catastrophic (like change the license) I won't be able to contact you for input.

imcotton commented 3 years ago

BTW I think it would be better done with CLA, but I want to make myself clear in advance that I'm willing to give my authority in such case like changing the license etc., hope this makes it much easier to proceed in the future.