Closed D4nte closed 2 years ago
The dohdec README says:
https://github.com/hildjj/dohdec/blob/0cfe5e7409d2e1d4a987c59f21a00b76e88ca1ac/pkg/dohdec/README.md?plain=1#L26
Meaning that the first argument of lookup can take a string.
lookup
string
However, the types say:
https://github.com/hildjj/dohdec/blob/0cfe5e7409d2e1d4a987c59f21a00b76e88ca1ac/pkg/dohdec/types/doh.d.ts#L97
Meaning that the first argument of lookup can only be of type object | DOH_LookupOptions
object | DOH_LookupOptions
With DOH_LookupOptions being defined as an object too:
DOH_LookupOptions
https://github.com/hildjj/dohdec/blob/0cfe5e7409d2e1d4a987c59f21a00b76e88ca1ac/pkg/dohdec/types/doh.d.ts#L109
README and types definition should match.
Thank you for finding this. The type definition is wrong. I'm working on a release right now.
The dohdec README says:
https://github.com/hildjj/dohdec/blob/0cfe5e7409d2e1d4a987c59f21a00b76e88ca1ac/pkg/dohdec/README.md?plain=1#L26
Meaning that the first argument of
lookup
can take astring
.However, the types say:
https://github.com/hildjj/dohdec/blob/0cfe5e7409d2e1d4a987c59f21a00b76e88ca1ac/pkg/dohdec/types/doh.d.ts#L97
Meaning that the first argument of
lookup
can only be of typeobject | DOH_LookupOptions
With
DOH_LookupOptions
being defined as an object too:https://github.com/hildjj/dohdec/blob/0cfe5e7409d2e1d4a987c59f21a00b76e88ca1ac/pkg/dohdec/types/doh.d.ts#L109
README and types definition should match.