hildjj / node-cbor

Encode and decode CBOR documents, with both easy mode, streaming mode, and SAX-style evented mode.
MIT License
356 stars 73 forks source link

include types for cbor-web #177

Closed rouzwelt closed 1 year ago

rouzwelt commented 1 year ago

add types (dts) to cbor-web when they are generated for cobr package, so cbor-web can be used in typescript browser projects easily.

this is the simplest solution I could come up with to include types for cbor-web, however better solutions possibly can be achieved by original authors as they are much more familar with the monorepo structure.

rouzwelt commented 1 year ago

about your question, well I understand your point, however bundling, pollyfilling for browser is really prone to stupid errors, at least in my experience, so personally if there is a package for browser that is already available that takes care of those things, I'd rather use that, it's just easier imo.

rouzwelt commented 1 year ago

hey @hildjj , let me know if the update is ok now, I would really appreciate it if you can consider the merge if all is fine. thank you

NanezX commented 1 year ago

Waiting for this! It would be better for me having the types availables for cbor-web too!

rouzwelt commented 1 year ago

@hildjj hey man, are good to merge? I'd really appreciate it we can sort this out soon.

NanezX commented 1 year ago

Awesome! Thanks ❤️

rouzwelt commented 1 year ago

thank you a lot man, really appreciate it 🙏🏻 just wondering does it automatically publish on npm? or if not is it possible for you to publish this so we can get it from npm?

hildjj commented 1 year ago

No, this won't publish automatically. It takes a ton of manual work to get a release out, and there's a bunch of stuff I need to fix before a release will work. I'll get to it eventually, but it's not going to happen for a week or two. You can use a github dependency until then: npm install hildjj/cbor might do it.

rouzwelt commented 1 year ago

ok got it, well thank you, I'll be patiently waiting for it. keep up your great work 👍🏻