Indefinite byte arrays should be parsed as Buffer

hildjj / node-cbor

Encode and decode CBOR documents, with both easy mode, streaming mode, and SAX-style evented mode.

MIT License

362 stars 74 forks source link

Indefinite byte arrays should be parsed as Buffer #59

Closed maghis closed 7 years ago

maghis commented 7 years ago

Currently the decoder returns a string (missing a break).

hildjj commented 7 years ago

fantastic catch on the break's. I had tests for this already, but apparently NONE of my decode tests were actually being run anymore. Fixed that, without taking your patch directly. Hope you're not offended. New release coming soon after I add a ton of linting and ensure that the rest of the tests are working.