Updated CLI to accept --root

hildjj / node-websequencediagrams

Call the WebSequenceDiagram.com API.

31 stars 18 forks source link

Updated CLI to accept --root #19

Closed walkingriver closed 2 years ago

walkingriver commented 2 years ago

I saw that the API version of this command lets you specify the root URL in code, but not at the command line. This PR addresses that, adding --root (-r and WSD_ROOT) as CLI options.

coveralls commented 2 years ago

Coverage remained the same at 96.341% when pulling 974c21d8173d5eb7315e2c6b46035a90ffa30204 on walkingriver:feature-specify-root into 9f83b5405badf5a5229561f37a6e65ef3cfdd0cf on hildjj:main.

walkingriver commented 2 years ago

Do we need to bump its version number to 2.1.x or something? I'm not seeing a new version when I try to update it via npm.

hildjj commented 2 years ago

I haven't published yet, sorry. I think we need to do a major version bump because I removed support for node 12. Wanted to look at it again with fresh eyes before I pulled the trigger.

Everything else look ok to you in HEAD?

walkingriver commented 2 years ago

I haven't seen any issues, no. I do agree that a major bump is probably warranted, given that you are dropping support for Node 12.

hildjj commented 2 years ago

Released v3.0.0