Mdw #370 - Githubissues

hildogjr / KiCost

Build cost spreadsheet for a KiCad project.

MIT License

503 stars 98 forks source link

Mdw #370 #399

Closed mdeweerd closed 4 years ago

mdeweerd commented 4 years ago

Fixed issues related to variant handling.

If kicost.abc:manf# was handled before kicost:manf#, the latter value took precedence even if the variant abc was set. Fixed in his request.
kicost.abc:desc will no longer recognize 'desc' as a manufacturer. A regex was added to match ':distributor:field'

hildogjr commented 4 years ago

Thanks by fix the .yml file. Despite my experience with Git, I am not expert on CI.

mdeweerd commented 4 years ago

I am not CI expert either - some CI stuff has to be fixed further . Tests are not working because kicost is not installed. I will check this further (and I am adding another fix to fix Excel 2010 error).

hildogjr commented 4 years ago

Excel has been the most restrictive in my tests. Because the spreadsheet must be compatible with Microsof Excel, LibreOffice Calc and Google Spreadsheets, I could implement some features in the past.