search

hildogjr / KiCost

Build cost spreadsheet for a KiCad project.
MIT License
496 stars 97 forks source link

Tests not passing on Python 2.7 and 3.5 #442

Closed set-soft closed 3 years ago

set-soft commented 3 years ago

Just to document it until I figure out what are the errors.

After a lot of tweaks I managed to run tests/test.sh on Python 2.7, 3.5, 3.7 and 3.9. You can see the runs here: https://github.com/INTI-CMNB/KiCost/actions

This run: https://github.com/INTI-CMNB/KiCost/actions/runs/640793471 contains the generated files and logs so we can analyze them.

A quick look shows that some problems are just because the tests assumes some sorting. This can be fixed forcing a deterministic sort. But others are harder to figure out for me. In some cases it looks like the fault is in the reference and not in the generated files. Next week I'll try to analyze what's the problem. But right now you should assume the code is wrong and needs fixes.

set-soft commented 3 years ago

BTW: I had to disable the flake8 tests for errors (not just style) because it detected some serious errors. I guess they are in code that isn't currently used. But we must fix the problems before any release.