search

hildogjr / KiCost

Build cost spreadsheet for a KiCad project.
MIT License
496 stars 97 forks source link

Remove the obsolete kicost_gui_wxFormBuilder.py file. #443

Closed set-soft closed 3 years ago

set-soft commented 3 years ago

This file is no longer used and it contains many errors. I understand it was used to create the current formKiCost class, but keeping it is confusing and the code contains many errors.

hildogjr commented 3 years ago

This was something that I could finish.

kicost_gui_wxFormBuild.py is aumatically generated by a software called wxFormBuild ( kicost_gui_wxFormBuilder.fbp project file).

Geritaging this first file in kicost_gui.py will generate a better maintenance of the GUI (I so this structure on others KiCad plugins projects). kicost_gui.py keeps the code logic and kicost_gui_wxFormBuild.py all the graphical element generation.

set-soft commented 3 years ago

I suggest removing the file until it's finished. You can add the file to a branch, and merge the branch when the file is usable.

If we keep this file we must exclude it from flake8 testing because the file contains various errors (uses many stuff that isn't defined).

hildogjr commented 3 years ago

Agreed.