search

hildogjr / KiCost

Build cost spreadsheet for a KiCad project.
MIT License
494 stars 97 forks source link

Exclude libs from flake8 checks and fixed dummy-web-server.py for flake #484

Closed mdeweerd closed 3 years ago

mdeweerd commented 3 years ago

I started checking with flake8, ran into some issues:

set-soft commented 3 years ago

Exclusions should be handled by the .flake8 file.

It looks like your flake8 isn't reading it. Which version are you using?

BTW libs isn't part of this project.

mdeweerd commented 3 years ago

Hi

I thnk that the lib directory is there because of tox or so, it holds a directory 'python3.7' .

flake8 reports - "3.9.1 (mccabe: 0.6.1, pycodestyle: 2.7.0, pyflakes: 2.3.1) CPython 3.8.9 on CYGWIN_NT-10.0-19042"

I checked the .flake8 file which excludes the dummy-web-server.py , but that is no longer needed because I fixed the errors in ths branch. The exclusion can be replaced with lib.

I made a test just now, and the .flake8 file is working, I do not know what was the glitch.

I updated the branch accordingly, so it fixes the dummy web server's non-compliance with flake8 and it no longer has to be excluded from the checks.