search

hilios / jQuery.countdown

The Final Countdown plugin for jQuery
http://hilios.github.io/jQuery.countdown/
MIT License
2.3k stars 720 forks source link

Added TypeScript Definition #294

Open larrybahr opened 6 years ago

larrybahr commented 6 years ago

When Googling for TypeScript definition I found that other people were looking for them as well (#274), so I made one. Any feed back would be great.

larrybahr commented 6 years ago

I have no idea why the Travis CI build failed. I did not make any code changes, just added the definition file. The error is for PhantomJS when doing something with the fakeServer. @hilios, you may want to make sure that your npm test is still working

hilios commented 6 years ago

Thank you @larrybahr I will take a look!

larrybahr commented 6 years ago

@hilios do you plan to accept the pull request? Is there anything I can do to help with your decision?

hilios commented 5 years ago

Man thanks for your contribution. The only thing that bothers me are the failing tests, and would be great if you could add some tests for the typescript module as well. If everything is green I will push the merge button right away.

larrybahr commented 5 years ago

I understand your hesitation, but it looks like the last few pull requests have the same error. I also downloaded a clean copy of your repo and ran the "grunt test" which failed. Can you confirm that the test still works? Do I need a specific version of Node for this to work? Travis-ci is using v0.10.48. Is that required?

larrybahr commented 5 years ago

@hilios Did you confirm the test still works? The new code should not even hit a test case because it just describes the code (it is a type definition file).

larrybahr commented 5 years ago

@hilios I do not think the tests work. Can you confirm they are working for you.

larrybahr commented 4 years ago

@hilios I can see the last commit to this repo is Dec 31, 2016. The Travis CI builds look like they always fail even for the unmodified code in the master branch. Should I assume this project is dead and my pull request will never be merged?