hill-a / stable-baselines

A fork of OpenAI Baselines, implementations of reinforcement learning algorithms
http://stable-baselines.readthedocs.io/
MIT License
4.16k stars 725 forks source link

docker build fails with FileNotFoundError: 'stable_baselines/version.txt' #1066

Closed anj1 closed 3 years ago

anj1 commented 3 years ago

Following https://stable-baselines.readthedocs.io/en/master/guide/install.html, I tried:

docker pull stablebaselines/stable-baselines
make docker-gpu

But this fails with:

FileNotFoundError: [Errno 2] No such file or directory: 'stable_baselines/version.txt'

Manually entering the docker image and creating the /root/code/stable-baselines/stable_baselines/version.txt file solved the problem.

araffin commented 3 years ago

Hello, thanks for pointing out this issue, the current docker file is apparently missing that line (present in Stable-Baselines3): https://github.com/DLR-RM/stable-baselines3/blob/master/Dockerfile#L31

We would appreciate a PR that solves this issue ;)

anj1 commented 3 years ago

Cool https://github.com/hill-a/stable-baselines/pull/1067

araffin commented 3 years ago

Fixed in https://github.com/Stable-Baselines-Team/stable-baselines/pull/2