hilmarx / ipfswap

Fully trustless ERC20 Token Swaps using Ethereum & Kyber Network, hosted on IPFS & Dat
https://ipfswap.com
8 stars 15 forks source link

Get tokens and their icons from IPFS instead of Kyber/TrustWallet defaults, Bootstrap JS/CSS from IPFS #36

Closed danimesq closed 4 years ago

danimesq commented 4 years ago

Makes it more decentralized, and enables adding new tokens.

Signed-off-by: Daniell Mesquita daniellmesquita@protonmail.com

danimesq commented 4 years ago

In this case, why Dat instead of IPFS: can transparently update tokens list, without uploading a whole file for just changing a few characters.

hilmarx commented 4 years ago

@DaniellMesquita How do you ensure that the list of tokens taken from https://tokens.hashbase.io/currencies.json reflect the tokens tradeable on Kyber Network? There should not be any additional tokens in the feed that result in reverted tx on a smart contract level. An idea to make it even more decentralized would be to integrate IPFSWAP into Uniswap, which has permissionless token adding capabilities.

danimesq commented 4 years ago

How do you ensure that the list of tokens taken from https://tokens.hashbase.io/currencies.json reflect the tokens tradeable on Kyber Network?

The only thing is keeping it as-is, and only adding new tokens when Kyber announces it. I'll undo the new added tokens. So, only Kyber can add its new tokens?

danimesq commented 4 years ago

Using IPFS instead of Dat. Now, Kyber token list is static and more trustworthy than getting it from Kyber server. I don't think it adds new tokens so often. When new token is add, just update its address.

danimesq commented 4 years ago

@hilmarx

hilmarx commented 4 years ago
Screenshot 2019-11-05 at 21 35 54

fetching icons from IPFS does not work "GET /stylesheets/searchicon.png HTTP/1.1" 404 -

danimesq commented 4 years ago

@hilmarx From which address? IPFS? Here it works. image image

danimesq commented 4 years ago

@hilmarx Is yet getting this error? It works in any test.

hilmarx commented 4 years ago

had a bad connection, IPFS seems to have problems then, but it worked when I tested it now.